-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DAS-2254: Updates README. Adds CONTRIBUTING.
- Adds ruff config to pyproject.toml
- Loading branch information
1 parent
defb750
commit a3dbd8a
Showing
3 changed files
with
86 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# Contributing to SMAP-L2-Gridding-Service | ||
|
||
Thanks for contributing! | ||
|
||
## Making Changes | ||
|
||
To allow us to incorporate your changes, please use the | ||
[Fork-and-Pull](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/getting-started/about-collaborative-development-models#fork-and-pull-model) | ||
development model: | ||
|
||
1. Fork this repository to your personal account. | ||
2. Create a branch and make your changes. | ||
3. Test the changes locally/in your personal fork. | ||
4. Submit a pull request to open a discussion about your proposed changes. | ||
5. The maintainers will talk with you about it and decide to merge or request | ||
additional changes. | ||
|
||
For larger items, consider contacting the maintainers first to coordinate | ||
development efforts. | ||
|
||
## Commits | ||
|
||
Our ticketing and CI/CD tools are configured to sync statuses amongst each | ||
other. Commits play an important role in this process. Please start all commits | ||
with the Jira ticket number associated with your feature, task, or bug. All | ||
commit messages should follow the format | ||
"[Jira Project]-XXXX - [Your commit message here]" | ||
|
||
## General coding practices: | ||
|
||
This repository adheres to Python coding style recommendations from | ||
[PEP8](https://peps.python.org/pep-0008/). Additionally, type hints are | ||
required in all function signatures. | ||
|
||
When adding or updating functionality, please ensure unit tests are added to | ||
an appropriate module in the `tests` sub directories, which cover each branch | ||
of the code. | ||
|
||
## Disclaimer | ||
|
||
SMAP-L2-Gridding-Service maintainers will review all pull requests submitted. Only requests that | ||
meet the standard of quality set forth by existing code, following the patterns | ||
set forth by existing code, and adhering to existing design patterns will be | ||
considered and/or accepted. | ||
|
||
For general tips on open source contributions, see | ||
[Contributing to Open Source on GitHub](https://guides.github.com/activities/contributing-to-open-source/). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
[tool.ruff.format] | ||
quote-style = "single" | ||
|
||
|
||
[[tool.mypy.overrides]] | ||
module = "harmony_service_lib.*" | ||
|