changed minimum version to 3.18 #3021
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rithvikrajraapeti what specifically caused the need for this change? Is CMake 3.16 causing issues here? |
|
For me it didnt run properly |
|
And even the version is outdated and it may cause some issues |
|
And its only considring the .cpp files and not the .h files if i added it |
|
Only for me |
|
And i saw this issue and this is common and you can change the version to 1.18 |
|
and what happend to a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
changed the minimum version to 3.18
Future Work
Note any additional work that will be done relating to this issue.