EDSC-4349: Adjustments to spatial filter dropdowns and buttons #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1846 +/- ##
==========================================
- Coverage 93.80% 93.78% -0.02%
==========================================
Files 778 778
Lines 18888 18900 +12
Branches 4849 4888 +39
==========================================
+ Hits 17717 17726 +9
+ Misses 1123 1099 -24
- Partials 48 75 +27 ☔ View full report in Codecov by Sentry. |
eudoroolivares2016
approved these changes
Jan 7, 2025
trevorlang
requested changes
Jan 7, 2025
| onClick={() => onItemClick('polygon')} | ||
| label="Select Polygon" | ||
| aria-label="Select Polygon" |
There was a problem hiding this comment.
I don't think we need labels or aria labels on all of these these dropdown items, since they are text buttons and the text tells the user what they will be selecting
| const buttons = drawToolbar.querySelectorAll('.leaflet-draw-draw-circle, .leaflet-draw-draw-polygon, .leaflet-draw-draw-rectangle, .leaflet-draw-draw-marker') | ||
| buttons.forEach((button) => { | ||
| if (button.classList.contains('leaflet-draw-draw-circle')) { | ||
| button.setAttribute('aria-label', 'Search by spatial circle') |
There was a problem hiding this comment.
These should read "Draw a [spatial method] on the map to select a spatial extent"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Ensuring the spatial buttons and consistent in both order and style, and adding aria-labels to them.
What is the Solution?
Updating the icons for spatial filter buttons to all match the same visual style. Making the spatial dropdown filters be left-aligned. Adding aria-labels to all the spatial filter buttons.
What areas of the application does this impact?
Testing
Reproduction steps
Attachments
Checklist