EDSC-4349 Addressing PR feedback

nasa · Jan 8, 2025 · 8965e61 · 8965e61
1 parent ee71568
commit 8965e61
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/static/src/js/components/SpatialDisplay/SpatialSelectionDropdown.jsx b/static/src/js/components/SpatialDisplay/SpatialSelectionDropdown.jsx
@@ -93,8 +93,6 @@ const SpatialSelectionDropdown = (props) => {
           as={Button}
           icon="edsc-icon-poly edsc-icon-fw"
           onClick={() => onItemClick('polygon')}
-          label="Select Polygon"
-          aria-label="Select Polygon"
         >
           <span>Polygon</span>
         </Dropdown.Item>
@@ -103,8 +101,6 @@ const SpatialSelectionDropdown = (props) => {
           as={Button}
           icon="edsc-icon-rect edsc-icon-fw"
           onClick={() => onItemClick('rectangle')}
-          label="Select Rectangle"
-          aria-label="Select Rectangle"
         >
           <span>Rectangle</span>
         </Dropdown.Item>
@@ -113,8 +109,6 @@ const SpatialSelectionDropdown = (props) => {
           as={Button}
           icon={FaCircle}
           onClick={() => onItemClick('circle')}
-          label="Select Circle"
-          aria-label="Select Circle"
         >
           <span>Circle</span>
         </Dropdown.Item>
@@ -123,8 +117,6 @@ const SpatialSelectionDropdown = (props) => {
           as={Button}
           icon={Map}
           onClick={() => onItemClick('point')}
-          label="Select Point"
-          aria-label="Select Point"
         >
           <span>Point</span>
         </Dropdown.Item>
@@ -133,8 +125,6 @@ const SpatialSelectionDropdown = (props) => {
           as={Button}
           icon={FaFile}
           onClick={() => onItemClick('file')}
-          label="Select Shapefile"
-          aria-label="Select Shapefile"
           disabled={disableShapefileSearch}
         >
           {

diff --git a/static/src/js/components/SpatialSelection/SpatialSelection.jsx b/static/src/js/components/SpatialSelection/SpatialSelection.jsx
@@ -536,13 +536,13 @@ const SpatialSelection = (props) => {
       const buttons = drawToolbar.querySelectorAll('.leaflet-draw-draw-circle, .leaflet-draw-draw-polygon, .leaflet-draw-draw-rectangle, .leaflet-draw-draw-marker')
       buttons.forEach((button) => {
         if (button.classList.contains('leaflet-draw-draw-circle')) {
-          button.setAttribute('aria-label', 'Search by spatial circle')
+          button.setAttribute('aria-label', 'Draw by a spatial circle')
         } else if (button.classList.contains('leaflet-draw-draw-polygon')) {
-          button.setAttribute('aria-label', 'Search by spatial polygon')
+          button.setAttribute('aria-label', 'Draw by a spatial polygon')
         } else if (button.classList.contains('leaflet-draw-draw-rectangle')) {
-          button.setAttribute('aria-label', 'Search by spatial rectangle')
+          button.setAttribute('aria-label', 'Draw by a spatial rectangle')
         } else if (button.classList.contains('leaflet-draw-draw-marker')) {
-          button.setAttribute('aria-label', 'Search by spatial coordinate')
+          button.setAttribute('aria-label', 'Draw by a spatial coordinate')
         }
       })
     }