-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
EDD-47: Users should be prompted about submitting their usage metrics (…
…#35) * EDD-47 Adding Metrics prompt * EDD-47 Updating tests * EDD-47 Preventing users from setting their preference to Select Option * EDD-47 Test fix * EDD-47 styling * EDD-47 Styling * EDD-47 Adding Settings tests * EDD-47 Adjusting migration script * EDD-47 Toast adjustments * EDD-47 Moving toast initializer * EDD-47: Add some tests to layout.jsx for metrics * EDD-47: fix test needs await call * EDD-47: Adding test assertions for metrics toast options * EDD-47 Changing allowedMetrics from string to bool * EDD-47 Updating tests * EDD-47 syntax change * Update src/app/dialogs/Settings/Settings.jsx Co-authored-by: Ed Olivares <[email protected]> * EDD-47 Cleaning up method names * EDD-47: Consolidate db migrations * EDD-47: fix setting types to be consistent * EDD-47: Settings shows the current value for whether user has accepted metrics or not * EDD-47 Updating test for consistency * EDD-47 Updating test --------- Co-authored-by: drewpesall <[email protected]> Co-authored-by: Ed Olivares <[email protected]>
- Loading branch information
1 parent
bb7484c
commit abf1d61
Showing
37 changed files
with
671 additions
and
86 deletions.
There are no files selected for viewing
9 changes: 9 additions & 0 deletions
9
migrations/20231221182834_add_allow_metrics_columns_to_preferences.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
exports.up = (knex) => knex.schema.table('preferences', (table) => { | ||
table.boolean('allowMetrics').defaultTo(false) | ||
table.boolean('hasMetricsPreferenceBeenSet').defaultTo(false) | ||
}) | ||
|
||
exports.down = (knex) => knex.schema.table('preferences', (table) => { | ||
table.dropColumn('allowMetrics') | ||
table.dropColumn('hasMetricsPreferenceBeenSet') | ||
}) |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.