Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

18 rebase add redis adapter #56

Merged
merged 13 commits into from
Oct 10, 2023
Merged

18 rebase add redis adapter #56

merged 13 commits into from
Oct 10, 2023

Conversation

asgibson
Copy link
Contributor

Supersedes #26

asgibson and others added 13 commits October 6, 2023 16:41
@asgibson
WIP:Added adapter
6f56ebf 
Still having some issues with couple of unit tests
message_listener untested
@asgibson
Updates to fix runtime issues
005a623 
Added optional data argument
Added super call
Removed stray print of new data
Fixed print in message_listener
Replace class accessors with self
@asgibson
Finalizing redis_adapter
8d7f584 
AdapterDataSource
  Removed print statements
  Overrode has_data to return instance value of new_data
test_redis_adapter
  Tested previously untested code
  Adjusted tests for changes to AdapterDataSource
@asgibson
The redis package added to requirements_pip
4e45fee
@asgibson
Fixed newlines at end of files
fb63e47
@asgibson
Updated redis test with new file conventions
adadb84
@the-other-james @asgibson
Move redis adapter, bring up to date with new on air data source
744db17
@the-other-james @asgibson
remove unused functions
694f6ce
@the-other-james @asgibson
Move common function to util
699e81e
@asgibson
Add connect and config subscriptions
a428921 
redis_adapter
  removed optional on super (already optional on class)
  added connect to init
  added subscribe to init
    now uses self.subscriptins from super init
    come from meta file
subscribe_messages now just subscribe
    takes array of string and sends them to subscribe as separated set
  parse_mata_data_file
    reparses json meta file due to other underlying generic
    reparse pulls out redis_subscriptions
    missing or empty sets subscriptions to empty
@asgibson
Fixes from expeimentation
530b5a3 
import of parseJson changed to absolute path
subscriptions done separately so none can be handled
@asgibson
colon for clarity
74b1bce
@cfirth-nasa
called_once->assert_called_once, works in py 3.10+
8146767
@asgibson asgibson linked an issue Oct 10, 2023 that may be closed by this pull request
Add Redis adapter #18
Closed
@asgibson asgibson mentioned this pull request Oct 10, 2023
Closed
Evana13G
Evana13G approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@Evana13G Evana13G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all straight forward, looks good to me

@Evana13G Evana13G merged commit 79f1609 into main Oct 10, 2023
2 checks passed
@asgibson asgibson deleted the 18-rebase-add-redis-adapter branch November 3, 2023 17:15
the-other-james pushed a commit to dennisafa/OnAIR that referenced this pull request Feb 23, 2024
@Evana13G
Merge pull request nasa#56 from nasa/18-rebase-add-redis-adapter
74e5f30 
18 rebase add redis adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evana13G Evana13G Evana13G approved these changes

@the-other-james the-other-james Awaiting requested review from the-other-james

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Redis adapter
4 participants
@asgibson @Evana13G @the-other-james @cfirth-nasa