Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix footer display #168

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Fix footer display #168

merged 3 commits into from
Jul 19, 2024

Conversation

melissawm
Copy link
Member

I did not notice before, but the recent pydata sphinx theme versions had unset our footer. I will send a PR later to fix the 0.5.0 docs in napari.github.io, but this fixes the immediate issues and changes the wording on the footer items as requested in #12 .

@melissawm melissawm mentioned this pull request Jul 15, 2024
Merged
@psobolewskiPhD
Copy link
Member

What do you think of Forum for image.sc and Ask a Q for Zulip?
Seems more natural?
Also, I recall there being some opposition to "Chat" due to connotations with AI chatbots.

@melissawm
Copy link
Member Author

We talked about it at the meeting and kinda decided on chat if I remember correctly? But yes, forum would be my first choice, I just followed the existing suggestions from the issue 😊

@psobolewskiPhD
Copy link
Member

I'm ambivalent about the chat part, but rather strongly feel that image.sc should be labeled as forum.

@DragaDoncila
Copy link
Contributor

I was the one with the concern about using chat, but I have actually revised that and am in favour as I think it's the option that makes most sense and is pretty unambiguous.

It's also totally different to how most chat bots are shown, with the little bubble in the right hand corner that inevitably makes some Clippy-like remark about helping you out.

@jni
Copy link
Member

jni commented Jul 16, 2024

I don't mind "ask a q" vs "forum" for image.sc, so I'm not gonna press merge. Since Peter feels strongly about Forum and it's shorter, let's go with that. I'm happy we got consensus on chat. 😊

@melissawm
Copy link
Member Author

Updated

@jni jni merged commit 48bc641 into napari:main Jul 19, 2024
1 check passed
jni pushed a commit to napari/docs that referenced this pull request Jul 19, 2024
@melissawm
Fix footer items (#456)
4c2449b 
# References and relevant issues
Should be merged after
napari/napari-sphinx-theme#168 comes out in a
new napari-sphinx-theme release.

# Description
Fixes footer display for PyData Sphinx Theme >= 0.15.3
@psobolewskiPhD psobolewskiPhD mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@melissawm @psobolewskiPhD @DragaDoncila @jni