Merge pull request #12 from napalm-automation-community/develop

Release 2.4.1
napalm-automation-community · Jul 17, 2019 · 648228a · 648228a
2 parents 2ed28e5 + cdb54dd
commit 648228a
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 2 deletions.
diff --git a/napalm_mos/mos.py b/napalm_mos/mos.py
@@ -444,7 +444,11 @@ def get_environment(self):
 
     def _transform_lldp_capab(self, capabilities):
         return sorted(
-            [LLDP_CAPAB_TRANFORM_TABLE[c.lower()] for c in capabilities.split(", ")]
+            [
+                LLDP_CAPAB_TRANFORM_TABLE[c.lower()]
+                for c in capabilities.split(", ")
+                if c
+            ]
         )
 
     def get_lldp_neighbors_detail(self, interface=""):

diff --git a/setup.py b/setup.py
@@ -8,7 +8,7 @@
 
 setup(
     name="napalm-mos",
-    version="2.4.0",
+    version="2.4.1",
     packages=find_packages(),
     author="Benny Holmgren, Brandon Ewing",
     author_email="[email protected], [email protected]",

diff --git a/test/unit/mocked_data/test_get_lldp_neighbors_detail/empty_cap/expected_result.json b/test/unit/mocked_data/test_get_lldp_neighbors_detail/empty_cap/expected_result.json
@@ -0,0 +1 @@
+{"et37": [{"parent_interface": "et37", "remote_port": "74:a0:2f:1c:1f:91", "remote_port_description": "eth1", "remote_chassis_id": "74:a0:2f:1c:1f:91", "remote_system_name": "localhost", "remote_system_description": "CentOS Linux 7 (Core) Linux 3.10.0-862.11.6.el7.x86_64 #1 SMP Tue Aug 14 21:49:04 UTC 2018 x86_64", "remote_system_capab": ["bridge", "router", "wlan-access-point"], "remote_system_enable_capab": []}]}
diff --git a/...nit/mocked_data/test_get_lldp_neighbors_detail/empty_cap/show_lldp_neighbor__verbose.text b/...nit/mocked_data/test_get_lldp_neighbors_detail/empty_cap/show_lldp_neighbor__verbose.text
@@ -0,0 +1,13 @@
+* et37
+  src: (mac address) 74:a0:2f:1c:1f:91
+  received: Wed Jul 17 10:09:25 2019 (0:00:15)
+  chassis id: (mac address) 74:a0:2f:1c:1f:91
+  port id: (mac address) 74:a0:2f:1c:1f:91
+  time to live: 120 secs
+  system name: localhost
+  system description: CentOS Linux 7 (Core) Linux 3.10.0-862.11.6.el7.x86_64 #1 SMP Tue Aug 14 21:49:04 UTC 2018 x86_64
+  system capability: {'enabled': '', 'capabilities': 'mac-bridge,wlan-access-point,router'}
+  port description: eth1
+  IEEE 802.3 link aggr (3): {'capability': 'capable', 'status': 'not in aggregation', 'port id': '00 00 00 00'}
+  IEEE 802.3 mac phy cfg status (1): {'auto-neg status': 'enabled', 'auto-neg support': 'supported'}
+  end of lldpdu:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		{"et37": [{"parent_interface": "et37", "remote_port": "74:a0:2f:1c:1f:91", "remote_port_description": "eth1", "remote_chassis_id": "74:a0:2f:1c:1f:91", "remote_system_name": "localhost", "remote_system_description": "CentOS Linux 7 (Core) Linux 3.10.0-862.11.6.el7.x86_64 #1 SMP Tue Aug 14 21:49:04 UTC 2018 x86_64", "remote_system_capab": ["bridge", "router", "wlan-access-point"], "remote_system_enable_capab": []}]}