Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doc and build issue (for linux) #2071

Merged
merged 8 commits into from
Oct 11, 2024

Conversation

peppergrayxyz
Copy link
Contributor

@peppergrayxyz peppergrayxyz commented Sep 30, 2024

Build is not working due to following issues:

  • go is not documented as dependency in the description for Linux
GO	/home/user/repos/nanos/output/test/runtime/bin/webg
/bin/sh: line 1: go: command not found
  • there is an issue with a new line that is not printed due to echo not processing \n
VERSION	/home/user/repos/nanos/output/platform/pc/gitversion.c
CC	/home/user/repos/nanos/output/platform/pc/output/platform/pc/gitversion.o
/home/user/repos/nanos/output/platform/pc/gitversion.c:1:21: error: extra tokens at end of #include directive [-Werror]
    1 | #include <runtime.h>\nconst sstring gitversion = ss_static_init("243c5a2010916b8fd69f86b290d637ad0efc1dbd");
      |    

Test-Build is not working due to following issues:

  • ops is not documented as dependency in the description for Linux
=== RUN   TestE2E/packages/node_alloc
    e2e.go:181: Waiting for command to complete...
    e2e.go:207: Output: /bin/bash: line 1: ops: command not found
    e2e.go:208: ops exit code 127
  • udp_test.c doesn't check for parse errors
CC	/home/user/repos/nanos/output/test/unit/test/unit/udp_test.o
In file included from /usr/include/endian.h:35,
                 from /usr/include/sys/types.h:176,
                 from /usr/include/bits/socket.h:29,
                 from /usr/include/sys/socket.h:33,
                 from /usr/include/netinet/in.h:23,
                 from /usr/include/arpa/inet.h:22,
                 from /home/user/repos/nanos/test/unit/udp_test.c:8:
In function ‘__bswap_16’,
    inlined from ‘main’ at /home/user/repos/nanos/test/unit/udp_test.c:57:21:
/usr/include/bits/byteswap.h:37:10: error: ‘dport’ may be used uninitialized [-Werror=maybe-uninitialized]
   37 |   return __builtin_bswap16 (__bsx);
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
/home/user/repos/nanos/test/unit/udp_test.c: In function ‘main’:
/home/user/repos/nanos/test/unit/udp_test.c:31:9: note: ‘dport’ was declared here
   31 |     u16 dport;
      |         ^~~~~

Debug-Build is not working due to following issues:

  • storage.c prints a parameter, that doesn't exist
CC	/home/user/repos/nanos/output/platform/pc/src/kernel/storage.o
/home/user/repos/nanos/src/kernel/storage.c: In function ‘volume_add’:
/home/user/repos/nanos/src/kernel/storage.c:274:45: error: ‘size’ undeclared (first use in this function)
 274 |     storage_debug("new volume (%ld bytes)", size);
     |                                             
  • unix.c has an improper macro expansion
CC	/home/pepper/dev/repos/nanos/output/platform/pc/src/unix/unix.o
/home/pepper/dev/repos/nanos/src/unix/unix.c: In function ‘handle_protection_fault’:
/home/pepper/dev/repos/nanos/src/unix/unix.c:241:61: error: macro "ss" passed 11 arguments, but takes just 1
 241 |         pf_debug(format_protection_violation(vaddr, ctx, vm));
     |                                                             ^
In file included from /home/pepper/dev/repos/nanos/src/runtime/runtime.h:54,
                from /home/pepper/dev/repos/nanos/src/kernel/kernel.h:2,
                from /home/pepper/dev/repos/nanos/src/unix/unix_internal.h:3,
                from /home/pepper/dev/repos/nanos/src/unix/unix.c:1:

@peppergrayxyz peppergrayxyz force-pushed the fix_build_and_doc_issues branch from b79d6db to 6380597 Compare October 2, 2024 09:34
@peppergrayxyz peppergrayxyz changed the title fix doc and build issue fix doc and build issue (for linux) Oct 2, 2024
Copy link
Member

@francescolavra francescolavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments
Thanks

README.md Outdated Show resolved Hide resolved
test/unit/udp_test.c Outdated Show resolved Hide resolved
@peppergrayxyz peppergrayxyz force-pushed the fix_build_and_doc_issues branch from 69eea3f to 8970938 Compare October 9, 2024 15:48
README.md Outdated Show resolved Hide resolved
test/runtime/README.md Outdated Show resolved Hide resolved
test/runtime/README.md Outdated Show resolved Hide resolved
@peppergrayxyz peppergrayxyz force-pushed the fix_build_and_doc_issues branch from 8970938 to b060a6b Compare October 10, 2024 13:04
@peppergrayxyz
Copy link
Contributor Author

should be all resolved now, thanks for your help!

Copy link
Member

@francescolavra francescolavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@francescolavra francescolavra merged commit 4c77f77 into nanovms:master Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants