Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename async methods in Service layer according to convention #22

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

nanotaboada
Copy link
Owner

No description provided.

Copy link

codeclimate bot commented Dec 20, 2023

Code Climate has analyzed commit 498ae20 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d25e535) 22.52% compared to head (498ae20) 23.14%.

Files Patch % Lines
...re.Samples.WebApi/Controllers/PlayersController.cs 0.00% 4 Missing ⚠️
...spNetCore.Samples.WebApi/Services/PlayerService.cs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   22.52%   23.14%   +0.62%     
==========================================
  Files           2        2              
  Lines         111      108       -3     
  Branches       11       10       -1     
==========================================
  Hits           25       25              
+ Misses         86       83       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanotaboada nanotaboada merged commit c4d959f into master Dec 20, 2023
5 of 6 checks passed
@nanotaboada nanotaboada deleted the feature/async-methods branch December 20, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant