Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending this PR on behalf of @digitalocean.
tl;dr: We should use modern tools, if available :)
This solves many problems, which should be evident, but I'll note some of them:
Pipfile
(Pipenv's default, but optional, behavior)pip-tools
does solve many of these problems itself, and supportingrequirements.txt
should still be a target. Using https://buildpacks.io should make this relatively simple though, as Heroku supports both Pipenv andrequirements.txt
(andsetup.py
, secretly) at the same time. Pipenv is the documented and recommended tool, however.