Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected apache modules example #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

G3z
Copy link

@G3z G3z commented Oct 19, 2018

I think the example is clearer

Copy link
Contributor

@danhunsaker danhunsaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct direction - the example is currently incomplete! - but deviates from the way documentation examples are given elsewhere in the same file, as well as throughout other Nanobox documentation. Namely, the example should list the default values used by the engine if the option isn't explicitly given in the boxfile. Switch that over, and this should be merged pretty easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants