-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create requirement files for dev and prod #58
Create requirement files for dev and prod #58
Conversation
Rate Limit Exceeded@Arsentau has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 17 minutes and 1 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, convert this PR to a draft and then mark it as ready for review again to re-trigger the review. Alternatively, you can push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per repository. WalkthroughThe changes primarily focus on refining the project's dependencies and updating the installation instructions. The shift in requirements suggests a move towards GraphQL functionality, with the removal of test data generation dependencies and the addition of Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (3)
- examples/fastapi-gql/README.md (1 hunks)
- examples/fastapi-gql/requirements-dev.txt (1 hunks)
- examples/fastapi-gql/requirements-prod.txt (1 hunks)
Files skipped from review due to trivial changes (3)
- examples/fastapi-gql/README.md
- examples/fastapi-gql/requirements-dev.txt
- examples/fastapi-gql/requirements-prod.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd13963
to
204f501
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
What's this PR do?
Summary of changes in this PR or what it accomplishes.
Given that requiremets file has the dependencies for development and for production mixed.
The dependencies were splited in two separate files:
Besides that Readme file was updated with the corresponding references
@ulises-jeremias @matiasz8
Summary by CodeRabbit
fastapi-gql
andfastapi-base
projects. The new instructions provide separate steps for installing development and production requirements.fastapi-gql
project with the addition of thestrawberry-graphql
dependency.factory-boy
,Faker
, andflake8
dependencies from thefastapi-gql
project. These tools were previously used for test data generation but are no longer needed.factory-boy
,Faker
, andflake8
to the development requirements for thefastapi-gql
project, enhancing the development and testing process.