Integration updates (#1)

.ruby-version

@@ -0,0 +1 @@
+2.7.8

README.md

@@ -1,4 +1,4 @@
-# Namely Ruby Whiff
+# :nose: Namely Ruby Whiff
 
 Namely Ruby Whiff is a Ruby gem that contains common Rubocop configurations to use in your Ruby projects. New tools will be added over time, the next being ruby critic.
 
@@ -7,7 +7,7 @@ Namely Ruby Whiff is a Ruby gem that contains common Rubocop configurations to u
 To install Namely Ruby Whiff, simply add it to your Gemfile:
 
 ```ruby
-gem 'namely-ruby-whiff'
+gem 'namely_ruby_whiff', git: 'https://github.com/namely/namely_ruby_whiff.git', branch: 'master', require: false
 ```
 
 And then run `bundle install`.
@@ -34,3 +34,28 @@ The gem also includes `rubocop-changes` a tool to apply Rubocop to only the file
 ```bash
 bundle exec rubocop-changes
 ```
+
+## Caveats
+
+When adding an additional file to a rule for exclusion, the excluded files from the base config also have to be added to the local config. For example:
+
+```
+# in the base config from this gem
+Lint/RescueException:
+  Exclude:
+    - 'app/lib/koala/evaluator.rb'
+
+
+# in your local project's config
+
+## this will no longer exclude the koala file from base
+Lint/RescueException:
+  Exclude:
+    - 'app/my_weird_file.rb'
+
+## this will work as intended
+Lint/RescueException:
+  Exclude:
+    - 'app/lib/koala/evaluator.rb'
+    - 'app/my_weird_file.rb'
+```

config/rubocop-rails.yml

@@ -7,5 +7,9 @@ inherit_from:
 
 AllCops:
   Exclude:
+    - 'bin/**/*'
     - 'db/**/*'
-  TargetRubyVersion: 2.6
+    - 'gen/**/*'
+    - 'protorepo/**/*'
+  # rubocop checks .ruby-version for version
+  # TargetRubyVersion: 2.6

config/rubocop/layout.yml

@@ -6,6 +6,11 @@ Layout/FirstMethodArgumentLineBreak:
 
 Layout/MultilineAssignmentLayout:
   Enabled: true
+  EnforcedStyle: new_line
 
 Layout/LineLength:
   Max: 120
+
+Layout/SpaceInsideStringInterpolation:
+  Enabled: true
+  EnforcedStyle: no_space

config/rubocop/lint.yml

@@ -10,8 +10,7 @@ Lint/ShadowedException:
 Lint/RescueException:
   Exclude:
     - 'app/lib/koala/evaluator.rb'
-    - 'app/services/net_suite/gl_org_units_service.rb'
 
-Lint/UnifiedInteger:
-  Exclude:
-    - 'app/models/type_for_field.rb'
+## New Cops
+Lint/NonDeterministicRequireOrder:
+  Enabled: true

config/rubocop/metrics.yml

@@ -5,9 +5,7 @@ Metrics/BlockLength:
   Max: 40
   Exclude:
     - 'config/routes.rb'
-    - 'spec/factories.rb'
     - 'spec/**/*_spec.rb'
-    - 'app/workers/net_suite_export_job.rb'
 
 Metrics/ClassLength:
   Max: 300

config/rubocop/rails.yml

@@ -18,3 +18,12 @@ Rails/SaveBang:
 
 Rails/SkipsModelValidations:
   Enabled: false
+
+## New Cops
+Rails/FilePath:
+  Enabled: true
+  EnforcedStyle: arguments
+
+RSpec/EmptyLineAfterExample:
+  Enabled: true
+  AllowConsecutiveOneLiners: true

config/rubocop/rspec.yml

@@ -16,9 +16,18 @@ RSpec/MultipleExpectations:
 RSpec/NestedGroups:
   Max: 5
 
-RSpec/LetSetup:
-  Exclude:
-    - 'spec/mailers/gl_sync_mailer_spec.rb'
-
 RSpec/NamedSubject:
   Enabled: false
+
+## New cops
+RSpec/RepeatedExampleGroupDescription:
+  Enabled: false
+
+RSpec/RepeatedExampleGroupBody:
+  Enabled: false
+
+RSpec/EmptyLineAfterExample:
+  Enabled: true
+
+RSpec/LeakyConstantDeclaration:
+  Enabled: true

config/rubocop/style.yml

@@ -7,20 +7,13 @@ Style/ClassVars:
 
 Style/DateTime:
   Enabled: true
-  Exclude:
-    - 'app/workers/sync_job.rb'
 
 Style/Documentation:
   Enabled: false
 
-Style/EachWithObject:
-  Exclude:
-    - 'app/models/namely_importer.rb'
-
 Style/FrozenStringLiteralComment:
   Exclude:
     - 'app/lib/koala/evaluator.rb'
-    - 'spec/features/**/*_spec.rb'
 
 Style/GuardClause:
   MinBodyLength: 4
@@ -37,9 +30,5 @@ Style/MissingRespondToMissing:
 Style/MultilineMethodSignature:
   Enabled: true
 
-Style/MutableConstant:
-  Exclude:
-    - 'app/models/net_suite/constants.rb'
-
 Style/Send:
   Enabled: true

namely_ruby_whiff.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name = 'namely_ruby_whiff'
-  spec.version = '0.0.2'
+  spec.version = '0.0.3.1'
   spec.summary = 'A set of configurations to support high quality Ruby code.'
   spec.authors = ['[email protected]']
   spec.files = []