Skip to content

Commit

Permalink
Merge pull request #23 from namely/bd/update-linting-deps
Browse files Browse the repository at this point in the history
9.0.0: upgrade peer deps: @typescript-eslint and eslint plugins
  • Loading branch information
bdefore authored Dec 14, 2021
2 parents c44e6d8 + 0494303 commit 30f6362
Show file tree
Hide file tree
Showing 9 changed files with 906 additions and 592 deletions.
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
14.18.1
16 changes: 16 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,22 @@

_Note: `eslint-config-namely` adheres to [semantic versioning](https://semver.org/)._

## 9.0.0 (Dec 8, 2021)

- [breaking]: peer dep upgrade: @typescript-eslint/eslint-plugin
- [breaking]: peer dep upgrade: @typescript-eslint/parser
- [breaking]: peer dep upgrade: eslint-plugin-import
- [breaking]: peer dep upgrade: eslint-plugin-jest
- [breaking]: peer dep upgrade: eslint-plugin-jsx-a11y
- [breaking]: peer dep upgrade: eslint-plugin-promise
- [breaking]: peer dep upgrade: eslint-plugin-react
- [breaking]: peer dep upgrade: eslint-plugin-react-hooks
- allow v8 of eslint in addition to v7. note that some plugins may not work properly with it yet.
- override to disable react/require-default-props
- override to disable react/function-component-definition
- updated internal dependencies
- add an .nvmrc

## 8.0.0 (Dec 7, 2021)

- [breaking]: use @babel/eslint-parser instead of no longer maintained babel-eslint
Expand Down
1 change: 1 addition & 0 deletions babel.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module.exports = {};
49 changes: 24 additions & 25 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,47 +1,46 @@
{
"name": "@namely/eslint-config-namely",
"version": "8.0.0",
"version": "9.0.0",
"description": "Namely's ESLint config",
"main": "index.js",
"scripts": {
"check-prettier-conflicts": "eslint --print-config *.js | eslint-config-prettier-check",
"lint": "eslint .",
"pretty-quick": "pretty-quick",
"print-config": "eslint --print-config *.js"
},
"dependencies": {
"eslint-config-airbnb": "^18.0.1",
"eslint-config-prettier": "^6.5.0"
"eslint-config-airbnb": "^18.2.1"
},
"devDependencies": {
"@babel/core": "^7.1.0",
"@babel/eslint-parser": "^7.16.3",
"@typescript-eslint/eslint-plugin": "^2.6.0",
"@typescript-eslint/parser": "^2.6.0",
"eslint": "^7.32.0",
"eslint-plugin-import": "^2.16.0",
"eslint-plugin-jest": "^23.0.2",
"eslint-plugin-jsx-a11y": "^6.2.1",
"eslint-plugin-promise": "^4.0.1",
"eslint-plugin-react": "^7.16.0",
"eslint-plugin-react-hooks": "^2.2.0",
"@typescript-eslint/eslint-plugin": "^5.6.0",
"@typescript-eslint/parser": "^5.6.0",
"eslint": "^8.4.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-import": "^2.25.3",
"eslint-plugin-jest": "^25.3.0",
"eslint-plugin-jsx-a11y": "^6.5.1",
"eslint-plugin-promise": "^5.2.0",
"eslint-plugin-react": "^7.27.1",
"eslint-plugin-react-hooks": "^4.3.0",
"husky": "^3.0.9",
"prettier": "^1.16.4",
"pretty-quick": "^2.0.0",
"typescript": "^3.6.4"
"prettier": "^2.5.1",
"pretty-quick": "^3.1.2",
"typescript": "^4.5.2"
},
"peerDependencies": {
"@babel/core": "^7.1.0",
"@babel/eslint-parser": "^7.16.3",
"@typescript-eslint/eslint-plugin": "^2.6.0",
"@typescript-eslint/parser": "^2.6.0",
"eslint": "^7.32.0",
"eslint-plugin-import": "^2.16.0",
"eslint-plugin-jest": "^23.0.2",
"eslint-plugin-jsx-a11y": "^6.2.1",
"eslint-plugin-promise": "^4.0.1",
"eslint-plugin-react": "^7.16.0",
"eslint-plugin-react-hooks": "^2.2.0"
"@typescript-eslint/eslint-plugin": "^5.6.0",
"@typescript-eslint/parser": "^5.6.0",
"eslint": "^7.32.0 || ^8.4.0",
"eslint-plugin-import": "^2.25.3",
"eslint-plugin-jest": "^25.3.0",
"eslint-plugin-jsx-a11y": "^6.5.1",
"eslint-plugin-promise": "^5.2.0",
"eslint-plugin-react": "^7.27.1",
"eslint-plugin-react-hooks": "^4.3.0"
},
"husky": {
"hooks": {
Expand Down
6 changes: 6 additions & 0 deletions rules/plugin-jest.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,10 @@ module.exports = {
'jest/expect-expect': 'off',
'jest/no-export': 'error',
},
// https://github.com/jest-community/eslint-plugin-jest/issues/686#issuecomment-739151588
settings: {
jest: {
version: 'latest',
},
},
};
2 changes: 2 additions & 0 deletions rules/plugin-react.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module.exports = {
rules: {
'react/default-props-match-prop-types': 'off',
'react/destructuring-assignment': 'off',
'react/function-component-definition': 'off',
'react/jsx-closing-bracket-location': 'off',
'react/jsx-curly-spacing': 'off',
'react/jsx-equals-spacing': 'off',
Expand All @@ -17,6 +18,7 @@ module.exports = {
'react/jsx-space-before-closing': 'off',
'react/jsx-tag-spacing': 'off',
'react/no-multi-comp': 'off',
'react/require-default-props': 'off',
'react/sort-prop-types': ['warn', { requiredFirst: true }],
'react/state-in-constructor': 'off',
'react/static-property-placement': 'off',
Expand Down
2 changes: 1 addition & 1 deletion rules/style.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module.exports = {
extends: ['prettier', 'prettier/react'],
extends: ['prettier'],
rules: {
'func-names': 'error',
'linebreak-style': 'off',
Expand Down
2 changes: 1 addition & 1 deletion rules/typescript.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = {
plugins: ['@typescript-eslint'],
extends: ['plugin:@typescript-eslint/recommended', 'prettier/@typescript-eslint'],
extends: ['plugin:@typescript-eslint/recommended'],
rules: {
'@typescript-eslint/array-type': [
'error',
Expand Down
Loading

0 comments on commit 30f6362

Please sign in to comment.