Bump to ts-proto 1.165.0 to fix tsc compile error #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version has an issue that makes it generate typescript that no longer compiles properly: ``` src/gen/google/protobuf/timestamp.ts:2:23 - error TS2497: This module can only be referenced with ECMAScript imports/exports by turning on the 'esModuleInterop' flag and referencing its default export. 2 import * as Long from "long"; ``` This error originates from this file in ts-proto: https://github.com/stephenh/ts-proto/blob/v1.138.0/integration/simple/google/protobuf/timestamp.ts And is fixed in the 1.165.0 version of the same file: https://github.com/stephenh/ts-proto/blob/v1.165.0/integration/simple/google/protobuf/timestamp.ts
|
ping @ido-namely |
|
Bump @ido-namely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version has an issue that makes it generate typescript that no longer compiles properly:
This error originates from this file in ts-proto: https://github.com/stephenh/ts-proto/blob/v1.138.0/integration/simple/google/protobuf/timestamp.ts
And is fixed in the 1.165.0 version of the same file: https://github.com/stephenh/ts-proto/blob/v1.165.0/integration/simple/google/protobuf/timestamp.ts