Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Swift language support #219

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Added Swift language support #219

wants to merge 8 commits into from

Conversation

bourquep
Copy link

@bourquep bourquep commented Dec 1, 2020

This adds support for Swift 5 code generation, using the official grpc-swift plugin (which itself uses Apple's swift-protobuf code generator plugin).

Possible values for --swift-opt are documented here.

Possible values for --grpc-swift-opt are documented here.

This uses the latest -alpha release of grpc-swift, which is deemed production-ready by the team even though it has the -alpha tag.

@troyswanson
Copy link

I'm a user, not a maintainer, but I would love to have this! Thanks 😄

ARG grpc_swift_version

WORKDIR /tmp
RUN git clone --depth 1 -b $grpc_swift_version https://github.com/grpc/grpc-swift.git

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems as though Apple has an official plugin for this now: https://github.com/apple/swift-protobuf

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not quite the same thing. swift-protobuf is a package that can [de]serialize protobuf-encoded messages. grpc-swift is the grpc runtime, allowing to implement grpc clients and servers in Swift.

@jcburley
Copy link
Collaborator

@bourquep – if you're still interested in this, please refresh and we'll take a fresh look at merging it. Else, feel free to close it out. Thanks!

@bourquep
Copy link
Author

@jcburley We are not using this image anymore, we've switch to using buf.build

But I can still update the PR and have it merged, because there seems to be interest from other folks.

@jcburley
Copy link
Collaborator

@jcburley We are not using this image anymore, we've switch to using buf.build

But I can still update the PR and have it merged, because there seems to be interest from other folks.

That's be great, thanks! If possible, please include test coverage and clean up any Codacy stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants