Support generate java-lite binding. #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@puppywang – if you're still interested in this, please refresh the PR and we'll take a fresh look at it. Else, feel free to close it out. Thanks! |
|
@jcburley I've update the PR with latest branch, please kindly help to review, thanks. |
Can you possibly add a test or two? Thanks! |
Test added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The java lite runtime has a much smaller code size which makes it more suitable to be used on Android. and it also works better with Proguard because it doesn’t rely on Java reflection and is optimized to allow as much code stripping as possible.
The support for javalite is very simple, just add "lite:" prefix to grpc_out and java_out, please kindly to accept this PR, thanks.