Added support for nanopb #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ido-namely
reviewed
Jan 6, 2022
There was a problem hiding this comment.
@joaquimjmsilva thank you for this contribution, apologies for the major delay in our response.
If you're still interested in seeing this PR merged, will you mind adding tests?
Thanks again, much appreciated!
Comment on lines
+80
to
+82
| python \ | ||
| py2-pip && \ | ||
| pip install protobuf |
There was a problem hiding this comment.
can you explain why the python packages are necessary?
does the plugin require them? because looking at the download page it seems like all the dependencies are included, no?
Additionally, I wonder if we should specify the version of this packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for nanopb protoc plugin.
https://jpa.kapsi.fi/nanopb/
Nanopb is a plain-C implementation that targets microcontrollers with tight memory constraints.