Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming readside #378

Closed
wants to merge 13 commits into from
Closed

Streaming readside #378

wants to merge 13 commits into from

Conversation

Tochemey
Copy link
Contributor

@Tochemey Tochemey commented Jun 11, 2021

related proto namely/chief-of-state-protos#25

FIRST THOUGHTS

@Tochemey Tochemey linked an issue Jun 11, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #378 (37a55dc) into master (1e8ad9a) will decrease coverage by 6.46%.
The diff coverage is 4.76%.

❗ Current head 37a55dc differs from pull request most recent head 4a3e157. Consider uploading reports for the commit 4a3e157 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   94.62%   88.15%   -6.47%     
==========================================
  Files          37       40       +3     
  Lines         744      802      +58     
  Branches       19       21       +2     
==========================================
+ Hits          704      707       +3     
- Misses         40       95      +55     
Impacted Files Coverage Δ
...om/namely/chiefofstate/config/ReadSideConfig.scala 100.00% <ø> (ø)
...readside/streaming/ReadSideJdbcStreamHandler.scala 0.00% <0.00%> (ø)
...ate/readside/streaming/ReadSideStreamHandler.scala 0.00% <0.00%> (ø)
.../readside/streaming/ReadSideStreamProjection.scala 0.00% <0.00%> (ø)
...namely/chiefofstate/readside/ReadSideManager.scala 58.13% <6.25%> (-16.87%) ⬇️
...ely/chiefofstate/config/ReadSideConfigReader.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e8ad9a...4a3e157. Read the comment docs.

@Tochemey Tochemey added the WIP label Jun 11, 2021
@klvmungai klvmungai closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC streaming read side interface
2 participants