Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recursive read side jdbc handler #281

Closed
wants to merge 10 commits into from

Conversation

AntonioYuen
Copy link
Contributor

@AntonioYuen AntonioYuen commented Apr 2, 2021

Recursive read side jdbc handler with exponential backoff
Decouples our jdbc processor retry from Akka

resolves #318

@AntonioYuen AntonioYuen added the WIP label Apr 2, 2021
@AntonioYuen AntonioYuen requested review from zenyui and Tochemey April 2, 2021 21:14
@AntonioYuen AntonioYuen marked this pull request as ready for review April 2, 2021 21:14
@AntonioYuen AntonioYuen requested a review from klvmungai as a code owner April 2, 2021 21:14
Copy link
Contributor

@Tochemey Tochemey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


val backoffSeconds: Long = Math.min(backOffSecondsMax, (backOffSecondsMin * Math.pow(1.1, numAttempts)).toLong)

Thread.sleep(Duration.ofSeconds(backoffSeconds).toMillis)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can we avoid this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tochemey Tochemey self-requested a review April 2, 2021 22:53
Copy link
Contributor

@Tochemey Tochemey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can we get a clear details on the use case we are solving? Also open an issue before this PR.

@Tochemey
Copy link
Contributor

Tochemey commented Apr 3, 2021

Please can we get a clear details on the use case we are solving? Also open an issue before this PR.

Never mind. @zenyui has explained to me. Kindly add it to the PR description.

@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #281 (be9e672) into master (5121c32) will decrease coverage by 0.38%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   77.91%   77.52%   -0.39%     
==========================================
  Files          42       42              
  Lines         797      801       +4     
  Branches       20       21       +1     
==========================================
  Hits          621      621              
- Misses        176      180       +4     
Impacted Files Coverage Δ
...ly/chiefofstate/readside/ReadSideJdbcHandler.scala 0.00% <0.00%> (ø)
...mely/chiefofstate/readside/ReadSideProcessor.scala 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5121c32...be9e672. Read the comment docs.

@Tochemey Tochemey self-requested a review April 4, 2021 10:21
@Tochemey Tochemey dismissed their stale review April 4, 2021 10:22

got the explanation needed

@Tochemey Tochemey marked this pull request as draft April 4, 2021 11:03
@Tochemey
Copy link
Contributor

Tochemey commented Apr 6, 2021

@AntonioYuen I think we can get this through.

@Tochemey Tochemey added this to the v0.9 milestone Apr 6, 2021
@Tochemey
Copy link
Contributor

@AntonioYuen it seems this PR is outdated and need some love.

@AntonioYuen
Copy link
Contributor Author

@AntonioYuen it seems this PR is outdated and need some love.

I will give it some love this week.

@Tochemey Tochemey deleted the recur_read_side_jdbc_handler branch August 25, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exponential backoff for projections
2 participants