-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recursive read side jdbc handler #281
Conversation
…ef-of-state into recur_read_side_jdbc_handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AntonioYuen I don't think you need to implement this. You can just see how it is set because java grpc does have that feature.
|
||
val backoffSeconds: Long = Math.min(backOffSecondsMax, (backOffSecondsMin * Math.pow(1.1, numAttempts)).toLong) | ||
|
||
Thread.sleep(Duration.ofSeconds(backoffSeconds).toMillis) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can we avoid this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AntonioYuen I don't think you need to implement this. You can just see how it is set because java grpc does have that feature.
Will look into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can we get a clear details on the use case we are solving? Also open an issue before this PR.
Never mind. @zenyui has explained to me. Kindly add it to the PR description. |
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 77.91% 77.52% -0.39%
==========================================
Files 42 42
Lines 797 801 +4
Branches 20 21 +1
==========================================
Hits 621 621
- Misses 176 180 +4
Continue to review full report at Codecov.
|
@AntonioYuen I think we can get this through. |
@AntonioYuen it seems this PR is outdated and need some love. |
I will give it some love this week. |
Recursive read side jdbc handler with exponential backoff
Decouples our jdbc processor retry from Akka
resolves #318