handle gRPC status error with no description (#128)

namely · Nov 5, 2020 · 9e72707 · 9e72707
1 parent f34b222
commit 9e72707
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/code/service/src/main/scala/com/namely/chiefofstate/AggregateCommandHandler.scala b/code/service/src/main/scala/com/namely/chiefofstate/AggregateCommandHandler.scala
@@ -218,7 +218,7 @@ class AggregateCommandHandler(
   def handleGrpcResponseFailure(status: Status): CommandHandlerResponse = {
     val rpcStatus: RpcStatus = RpcStatus()
       .withCode(status.getCode.value)
-      .withMessage(status.getDescription)
+      .withMessage(Option(status.getDescription).getOrElse(""))
 
     val failureResponse = FailureResponse()
       .withCustom(Any.pack(rpcStatus))

diff --git a/code/service/src/test/scala/com/namely/chiefofstate/AggregateCommandHandlerSpec.scala b/code/service/src/test/scala/com/namely/chiefofstate/AggregateCommandHandlerSpec.scala
@@ -358,6 +358,17 @@ class AggregateCommandHandlerSpec extends CustomActorTestkit("application.conf")
       actual.message shouldBe (status.getDescription())
     }
 
+    "handle failed gRPC status with no description" in {
+      val status: Status = Status.ABORTED
+      val exception = new StatusRuntimeException(status)
+      val cmdhandler = new AggregateCommandHandler(null, testHandlerSetting)
+      val result: CommandHandlerResponse = cmdhandler.handleRemoteResponseFailure(exception)
+      result.getFailure.failureType.isCustom shouldBe (true)
+      val actual = result.getFailure.getCustom.unpack(RpcStatus)
+      actual.code shouldBe (status.getCode.value)
+      actual.message shouldBe ("")
+    }
+
     "handle failed validations sent by command handler" in {
       val badStatus: Status = Status.INVALID_ARGUMENT.withDescription("very invalid")
       val exception: StatusRuntimeException = new StatusRuntimeException(badStatus)