Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add events field to support handling multiple events per one command #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add events field to support handling multiple events per one command #23

wants to merge 1 commit into from

Conversation

ido-namely
Copy link
Contributor

  1. Add events field to support handling multiple events per a single command.
  2. deprecate the event field (currently will be backwards compatible).

@ido-namely ido-namely mentioned this pull request May 24, 2021
Closed
Tochemey
Tochemey suggested changes May 24, 2021
View reviewed changes
Copy link
Contributor

@Tochemey Tochemey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have another endpoint to cater for the multiple events feature. It will make it clean and simple to deprecate the single event endpoint. Yeah as much as proto gives us the beauty of depreciation I am not too fun of it.

Also I know we might duplicate code in the implementation but this will b a necessary evil😁

Tochemey
Tochemey reviewed May 24, 2021
View reviewed changes
Copy link
Contributor

@Tochemey Tochemey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initiative @ido-namely.

zenyui
zenyui reviewed May 25, 2021
View reviewed changes
chief_of_state/v1/writeside.proto
// Events to append to the journal.
repeated google.protobuf.Any events = 2;
// 1. If both event and events fields are not set, COS will treat this command as a no-op.
// 2. If both event and events fields are set, the event field will be disregarded.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ido-namely update this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenyui zenyui zenyui left review comments

@Tochemey Tochemey Tochemey requested changes

@klvmungai klvmungai Awaiting requested review from klvmungai klvmungai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ido-namely @Tochemey @zenyui