Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker for production #1914

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

arthurpar06
Copy link
Contributor

@arthurpar06 arthurpar06 commented Dec 20, 2024

This PR introduces a Docker stack for production. The stack is based on caddy and serversideup/php-fpm, and it includes multiple containers to support a queue worker, a task runner, and http/https via Caddy.

As part of this update, I removed the sample module (which was unused) since it was installed via composer in the modules folder.

Additionally, this PR allows for the installation of phpVMS by manually creating a .env file and then setting up the first user and airline through the web installer.

Currently, the image is built locally, and some basic folders are mounted for data persistence. However, there are alternative approaches for handling this. A documentation update is planned to outline these options. We also intend to implement GitHub Actions for building this image and distributing it via Docker Hub, for those who prefer not to build the image themselves.

Closes #1815

Roadmap:

  • Create a custom image with the extensions we need, Composer, and (maybe) mariadb-client
  • Add an "installation" script to run "composer dump-autoload" on the first launch
  • Remove sample module
  • Create a .env.example file
  • Perform real-world testing
  • Update installer to support step3 only install
  • Build custom image in CI (will be done in another PR)
  • Update docs (will be done in another PR)

@arthurpar06 arthurpar06 marked this pull request as draft December 20, 2024 17:28
Copy link

gitguardian bot commented Dec 25, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
2856813 Triggered Generic Password 01b1a83 .env.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@arthurpar06 arthurpar06 marked this pull request as ready for review December 25, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Create Docker Image for "production" use
1 participant