-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker for production #1914
base: dev
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
2856813 | Triggered | Generic Password | 01b1a83 | .env.example | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This PR introduces a Docker stack for production. The stack is based on caddy and serversideup/php-fpm, and it includes multiple containers to support a queue worker, a task runner, and http/https via Caddy.
As part of this update, I removed the sample module (which was unused) since it was installed via composer in the modules folder.
Additionally, this PR allows for the installation of phpVMS by manually creating a
.env
file and then setting up the first user and airline through the web installer.Currently, the image is built locally, and some basic folders are mounted for data persistence. However, there are alternative approaches for handling this. A documentation update is planned to outline these options. We also intend to implement GitHub Actions for building this image and distributing it via Docker Hub, for those who prefer not to build the image themselves.
Closes #1815
Roadmap:
.env.example
file