Add bond interfaces supporting #37
Conversation
ObjatieGroba
commented
Mar 9, 2021
•
ObjatieGroba
commented
- Reformat keys with lower case. Replace '_' with '-'.
- Support multiword values on parsing
- Bonding support
- Add bond attributes checking
- Add bond settings validation
- Add bond configuration tests
ObjatieGroba
force-pushed
the
feature_bond_interfaces
branch
3 times, most recently
from
a6725df to
03bc049
Compare
debinterface/interfacesReader.py
Outdated
| sline = [x.strip() for x in line.split()] | ||
| sline = [x.strip() for x in line.split(None, 1)] | ||
|
|
||
| sline[0] = sline[0].lower().replace('_', '-') |
There was a problem hiding this comment.
There are no standard way to write such attributes.
It can be lower or upper case.
'-' and '_' are equal in this context.
Suggest to use lower-case for keys and some attribute values
|
Let's release |
debinterface/interfaces.py
Outdated
|
|
||
| return self.addAdapter({"name": name, 'bond-mode': mode, 'bond-slaves': ' '.join(slaves)}) | ||
|
|
||
| def validateBondSettings(self): |
There was a problem hiding this comment.
I would move that method into NetworkAdapterValidation
There was a problem hiding this comment.
Move to the new File infaterfacesValidation to class InterfacesValidator
| key (str): the option name | ||
| val (any): the option value | ||
| """ | ||
| key = key.lower().replace('_', '-') |
There was a problem hiding this comment.
Are you sure about that one ? It may break a keyword ?
There was a problem hiding this comment.
It should not break keyword. As NetworkManager sources says:
Normalize keys. Convert '_' to '-', as ifupdown accepts both variants.
There was a problem hiding this comment.
Sources of ifupdown cast all attr names into UPPER_SNAKE_CASE and accept any variants - lower or upper, '-' or '_' before writing it into OS
https://salsa.debian.org/debian/ifupdown/-/blob/master/execute.c#L41
There was a problem hiding this comment.
There was a problem hiding this comment.
But there are some options that should be this-case and neither another cases:
https://salsa.debian.org/debian/ifupdown/-/blob/master/config.c#L733
That's why I suggest to do such transformation
ObjatieGroba
changed the title
ObjatieGroba
force-pushed
the
feature_bond_interfaces
branch
from
6fc49bf to
99bbe55
Compare
…nclosed resources
ObjatieGroba
changed the title
