fix: Save new version of the workflow instead of the previous (no-changelog) #7428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7428 +/- ##
========================================
Coverage 33.55% 33.55%
========================================
Files 3398 3399 +1
Lines 207597 207453 -144
Branches 22428 22417 -11
========================================
- Hits 69652 69621 -31
+ Misses 136823 136704 -119
- Partials 1122 1128 +6
☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
core
krynble
reviewed
Oct 19, 2023
krynble
previously approved these changes
Oct 23, 2023
1 flaky test on run #2550 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Debug > should be able to debug executions |
Output
Screenshots
Video
|
|
Review all test suite changes for PR #7428 ↗︎
|
✅ All Cypress E2E specs passed |
krynble
approved these changes
Oct 23, 2023
|
✅ All Cypress E2E specs passed |
netroy
pushed a commit
that referenced
this pull request
Oct 24, 2023
…ngelog) (#7428) Github issue / Community forum post (link here to close automatically):
|
Got released with |
netroy
reviewed
Oct 24, 2023
| @@ -301,8 +301,8 @@ export class WorkflowsService { | |||
| ); | |||
| } | |||
|
|
|||
| if (isWorkflowHistoryLicensed()) { | |||
| await Container.get(WorkflowHistoryService).saveVersion(user, shared.workflow); | |||
| if (isWorkflowHistoryLicensed() && workflow.versionId !== shared.workflow.versionId) { | |||
MiloradFilipovic
added a commit
that referenced
this pull request
Oct 25, 2023
* master: (30 commits) 🚀 Release 1.14.0 (#7514) ci: Fix oclif manifest generation feat(Switch Node): Add support for infinite Switch outputs (#7499) 🚀 Release 1.13.0 (#7512) fix(core): Ensure nodes post-processors run in the correct order (#7500) feat(editor): Add PH tracking to event (#7511) fix(core): Fix workflow activation with history and workflow history for EE (no-changelog) (#7508) refactor(core): Make executions pruning more resilient (#7480) fix(Spreadsheet File Node): Fix include empty cells not working with v2 (#7505) fix(core): Create instance settings directory recursively (no-changelog) (#7506) fix(Microsoft SQL Node): Prevent SQL injection (#7467) refactor(core): Make pruning via lifecycle configuration in S3 mode mandatory (#7482) fix(core): Always derive `instanceId` from the encryption key (no-changlog) (#7501) fix(MQTT Trigger Node): Fix node causing a start up hang when active (#7498) feat: Collect usage metrics on license renewal (no-changelog) (#7486) fix(core): Fix `frontend.settings` external hook execution (#7496) fix(Redis Node): Fix adding sets data types (#7444) fix: Save new version of the workflow instead of the previous (no-changelog) (#7428) refactor(core): Abstract away InstanceSettings and `encryptionKey` into injectable services (no-changelog) (#7471) fix(Customer.io Node): Fix api endpoint when using EU region (#7485) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):