Convert edge command line options to a new parser #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually, I want to have each available transop register itself with a transop manager interface (similar to how the n3n_config_register_section is used to register available config options), however that is not ready yet. In a config file, I definitely want to use a descriptive string to configure the cipher used, so these numbers will be going away. The current commandline option will probably be deprecated, too, which would mean that nothing external is using a raw ID number for any cipher settings. For now, the less of evils seems to be to quick check against the bounds of the transform id. To ensure we have a known memory storage size for the config parser, this also changes the transop_id to be uint8_t.
Convert from storing string representation of a dotted quad netmask to simply using the mask length. This helps remove a bunch of double conversions and ultimately makes the tuntap config simpler and easier to refactor into using the new option parser. This commit will have broken every OS except for linux.
This reverts commit 9450795.
Since the inet_pton is unsupported on pre-Vista versions of windows, simply refuse to allow static addresses in that case. This is intended to be a temporary solution - when this is converted to the new option parser, a more permanent answer will be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This paves the way to add a proper config file, add built-in config help and should assist with consolidating the command line options for the supernode as well.