Container updates #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sure, these don't end up in the final build stage, but they *do* cause the builder to re-run anything after COPY . . if anything in, say, the docs/ dir changes.
Add documentation and example of building rootless by skipping tests. Also add configuration for running a supernode in a container. In my tests, the supernode didn't actually require --device and --cap-add, but I assume it might if it falls back to being used as a relay?
mattcen
commented
Dec 30, 2024
|
|
||
|
|
||
| FROM docker.io/library/debian:12 | ||
|
|
||
| COPY --from=builder /n3n/apps/n3n-edge /n3n-edge | ||
| COPY --from=builder /n3n/apps/n3n-supernode /n3n-supernode |
There was a problem hiding this comment.
I didn't get the impression that there is a "standard" port recommended for a supernode, otherwise I'd have put in an EXPOSE 1234/udp here, too.
There was a problem hiding this comment.
There is a default bind port of 7654, so that could be exposed
|
The supernode doesnt need the perms - when acting as the fallback relay, it just passes encrypted packets between edge nodes. |
|
Ah cool, well I've made a follow-up commit to address your comments if you'd like to add that too: mattcen@container-updates |
|
I'm always quick to merge a documentation patch - they are generally better than what was there before, so improvements can just be added |
|
whistles nonchalantly mattcen@container-updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my tests, the supernode didn't actually require
--deviceand--cap-add, but I assume it might if it falls back to being used as a relay?