Add pagination to management API #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This splits long-running queries into multiple chunks - Reducing the size of the needed memory buffer - Allowing less blocking of the main loop - This does open a race condition for the underlying data to change, but this is considered a reasonable trade off - The implementation is not efficient as we would need to implement persistent cursors accessing the uthash data to avoid multiple list scans.
Once again, deal with the issue that github actions uses a different compiler to Debian stable, and thus has a slightly different set of compile-time warnings that can occur when running the test suite.
Reverts change made because github actions said "automake is already installed"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows longer length replies from the management API, without stalling
the core daemon or requiring large amounts of RAM.
Adds a small change to the published API. Since the previous API
would have been broken for large results, no user visible changes in
functionality are actually happening (Either it was not broken
previously and it is unchanged now, or it was broken previously and
will now return a clearer error result now)
Also contains a bugfix to remove a memory leak