Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging improvements #4

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Logging improvements #4

merged 9 commits into from
Oct 31, 2023

Conversation

hamishcoleman
Copy link
Contributor

No description provided.

@hamishcoleman
Move logging into its own header
d492c61
@hamishcoleman
Move logging functions into their own file
55b1222
@hamishcoleman
Clean up old TODO now that logging has been factored out
5958280
@hamishcoleman
By making stderr the default for logging, we can reduce the API size
e7328b0
@hamishcoleman
Simplify logging with an early exit and reindent
472e9e3
@hamishcoleman
Only calculate date string when we need it
fd54564
@hamishcoleman
Remove obsolete comment
6101593
@hamishcoleman
Refactor logging to allow optional date prefix
91be2c5 
When the logging output is being sent to the journald, we want to avoid
having the datetime prefix added by the n3n logging - the log lines will
end up in the journal with both a n3n datestamp and a journal datestamp.

While adding this, refactor the function to remove duplication and
various overheads.  Reduces the stack usage and the number of times the
strings are scanned.
@hamishcoleman
Tune the trace level for some normal and expected events
e82f6cb
@hamishcoleman hamishcoleman merged commit f9d0768 into n42n:main Oct 31, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hamishcoleman