Bugs and leaks #36
Merged
Bugs and leaks #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hamishcoleman
commented
May 20, 2024
hamishcoleman
commented
- Use matching alloc and free functions with speck - fixes bug showing up on windows
- Look for additional speck memory leaks
- Try to remove or note how to remove memset from the PDU processing path
- Refactor decode_sock_payload() protocol-fault-workaround function to fully initialise its return buffer (See Fixed payload_sock not being cleared #32 and Check the initialization of n2n_sock_t according to the wire.c file #35)
The speck_init() function will always allocate its own buffer, so dont allocate one as that leads to memory leaks. In some configuations, the speck_init will not use the standard malloc() and this may cause issues when trying to use free() on the returned ctx. This issue definitely occurs with the Windows builds and lead to the supernode aborting with "exception code 0xc0000374 (Heap Corruption)" (Ref n42n#30)
It is simply a different name for speck_context_t, so use that name everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.