Simplify README and improve build docs #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debian package build automation will update this file to this version as part of the build process. This can also accidentally result in the package build version number showing as "dirty"
When building a PR merge, github will set GITHUB_REF to a value like "refs/pull/24/merge", which the openwrt mechanism will attempt to checkout, but that string is not acceptable. Switch to always using the commit hash as that should always be one that the openwrt git checkout process can find.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
- Coverage 48.94% 43.80% -5.14%
==========================================
Files 40 53 +13
Lines 6038 9253 +3215
==========================================
+ Hits 2955 4053 +1098
- Misses 3083 5200 +2117 ☔ View full report in Codecov by Sentry. |
…kets filled with other workarounds
Its starting to feel like the github runner just doesnt expose the merge as a cloneable SHA in any useful way. Since the openwrt build system /must/ clone a repo from somewhere, this makes it impossible to easily use it. TODO: construct a local file url for the cloning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.