Documentation and Packaging improvements #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debian package upstream versions can only have hyphens if there is a debian revision component at the end. Since our version number is automatically calculated by the git describe command, it is known to be correct - even if debian hates it - so append a debian revision component
…iplet options for autoconf
…built debs around
Avoid replicating commands by using the existing make target for install. Also start to move the spec file towards a somewhat more normal rpm build environment (actually building the source now). Finally, remove as much of the configure magic as is simple to do.
In the lower "level" config dumps, we dont need as much distinctive separation of the sections, so avoid adding them until we are also adding some of the help texts
Since most people who will be running the processes in the background will be doing this with some kind of process supervisor - which will be assisted by the daemon not forking, we can make the default case simpler. This also has the helpful side effect of allowing the removal of one more non-zero-default variable in the *_defaults() function.
Since we wish to use the git describe feature to create the versions, and that generates versions with dashes, and debian has specific requirements for versions that have dashes, we need to make the correct version number show up in the debian changelog. This is unfortunate, since it also means that we cannot call this package "native", however consistently using the exact VCS description is significantly more useful.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
- Coverage 46.30% 40.58% -5.72%
==========================================
Files 40 52 +12
Lines 6051 8961 +2910
==========================================
+ Hits 2802 3637 +835
- Misses 3249 5324 +2075 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of minor cleanups to make the documentation and man pages clearer and more consistant.
Major rewrite of the debian package building to make it significantly simpler (and hopefully closer to best practices)
A smaller reworking of the RPM package building with the same intent
Some command line option changes to bring things in line with how the daemons are usually used.