Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate supernode to use new config parser #12

Merged
merged 111 commits into from
Feb 12, 2024
Merged

Migrate supernode to use new config parser #12

merged 111 commits into from
Feb 12, 2024

Conversation

hamishcoleman
Copy link
Contributor

A number of documentation cleanups as well

@hamishcoleman
Start migrating the CLI code so it can be shared with the supernode
5af633e
@hamishcoleman
Prep for converting supernode config parsing
253e545
@hamishcoleman
Convert the simple options
e1f9479
@hamishcoleman
Move hash initialiser to match edge location
9d3f11d
@hamishcoleman
Refactor this option parser to try and make it clearer
2a2c63c
@hamishcoleman
Change option to boolean and give it a neutral tense
b1e5f44
@hamishcoleman
Move config variable into config structure
1af46a2
@hamishcoleman
Convert option to new parser
30ce701
@hamishcoleman
Convert option to new parser
4396b63
@hamishcoleman
Convert option to new parser
b888c9e
@hamishcoleman
Remove unused forward definition
142b7c2
@hamishcoleman
Add forward definitions to headers
41b5487
@hamishcoleman
Field is used as a bool, so simply make it a bool
11d7d08
@hamishcoleman
Migrate some init work from supernode.c into correct place
865a933
@hamishcoleman
Find and squash another windows incompatibility
9f4ee48
@hamishcoleman
Move some forward definitions into a real header
3928e8b
@hamishcoleman
Minor header reordering to keep the related items close to each other
e2e343e
@hamishcoleman
Move getopt mapping function to a common file so it can be shared
788c79d
@hamishcoleman
Add the option mapping parser to the supernode
f275667
@hamishcoleman
Add generic option setter
d4fcdeb
@hamishcoleman
Initialise the default user and group the same as the edge daemon
0a49812
@hamishcoleman
Factor out the mapped options help generate so it can be shared
702982e
@hamishcoleman
Fix supernode build
4cd86f1
@hamishcoleman
Convert supernode to new options parser (with some naive option choic…
374e23d 
…es that need fixing)
@hamishcoleman
Cleanup missed bit of udp management socket
2a777b7
@hamishcoleman
Rationalise those sn CLI options that can use -O
ed2ca75
@hamishcoleman
Merge loadFromCLI and get_option, similar to in edge
f35e26f
@hamishcoleman
Address linter concerns
628b93a
@hamishcoleman
Address linter concerns
3dfb529
@hamishcoleman
Ensure the sessiondir is setup for supernode
e42f3e1
@hamishcoleman
Make it easier to see what is happening within the supernode integrat…
ad671c6 
…ion test
@hamishcoleman
Simplify the supernode -l option enough that it can be migrated to th…
c9c0be6 
…e new parser
@hamishcoleman
Convert supernode daemon -l option to new parser
2a6ce61
@hamishcoleman
Try to reduce possible confusion in config help.
fedaa9e 
Since the two supernode list variables are special cased, they dont get
the usual commented out but still present help output when their list is
empty.  This is confusing.

They still output their help text, if that level of output is requested.
This is also confusing.

They get strange blank lines after them.  This could be confusing.

Rather than trying to do three confusing things before breakfast, reduce
this confusion a little bit.  The least we can do is output a commented
out and empty version of the list.
@hamishcoleman
Remove orphaned supernode option data that have already been removed …
d2e4c80 
…from the code
@hamishcoleman
Simplify the auto ip address parser
a13c3e0
@hamishcoleman
Move autoip validation outside of getopt parsing
1bb0d24
@hamishcoleman
Address linter concerns
58c04e4
@hamishcoleman
Move the auto ip settings into the conf struct (and store them in net…
62b0e51 
…work byte order)
@hamishcoleman
Be sure to mention the HTTP pages
de897ee
@hamishcoleman
Remove/rename the obsolete supernode -c option
4b1d2a2
@hamishcoleman
Remove more non standard init code.
85df80d 
By adding an initfunc to the random number generator, we can ensure that
the same init sequence is done on all apps.  This also helps to
modularise the random number code and reduce the number of headers
needed.
@hamishcoleman
Simplify the ifdefs
23732ca
@hamishcoleman
Convert the supernode -a option to use new parser
08418a9
@hamishcoleman
Change the indent to make the data more readable
d9e870b
@hamishcoleman
Fix tests by removing changing data and adding the new options
4637dc4
@hamishcoleman
Fix build by actually adding missing conversions
4f40291
@hamishcoleman
Allow the readable struct to not fail the linter
b11d713
@hamishcoleman
Finally realise I accidentally staged the rename, but not any of the …
9b8a576 
…matching changes
@hamishcoleman
The reason for this is now documented in the src/random_numbers.c
ef9b33d
@hamishcoleman
Fix incorrect command name
f0f5784
@hamishcoleman
Remove comment as the issue is solved with moving the definition around
823cc10
@hamishcoleman
Show config dump, with supernode defaults
e0a4d37 
Since the supernode has a different set of defaults, the config dump is
actually different to that shown by the edge.  This cut-and-pastes the
debug config CLI sub commands from edge into supernode.
@hamishcoleman
Refactor the random seed to expose the components
bda0ea0
@hamishcoleman
Allow checking where random seeds come from
2113de7
@hamishcoleman
Address linter concerns
b478880
@hamishcoleman
Fix package builds after example file rename
523bf1d
@hamishcoleman hamishcoleman self-assigned this Feb 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024 •
edited
Loading

Codecov Report

Attention: 321 lines in your changes are missing coverage. Please review.

Comparison is base (37e4ff4) 43.48% compared to head (523bf1d) 40.57%.

Files Patch % Lines
apps/supernode.c 0.00% 110 Missing ⚠️
src/conffile.c 40.00% 87 Missing ⚠️
src/metrics.c 15.62% 27 Missing ⚠️
src/sn_utils.c 70.78% 26 Missing ⚠️
apps/edge.c 34.61% 17 Missing ⚠️
src/peer_info.c 56.25% 14 Missing ⚠️
src/management.c 0.00% 13 Missing ⚠️
src/n2n.c 50.00% 12 Missing ⚠️
src/random_numbers.c 75.00% 7 Missing ⚠️
src/edge_utils.c 72.72% 3 Missing ⚠️
... and 3 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   43.48%   40.57%   -2.91%     
==========================================
  Files          39       52      +13     
  Lines        5899     8959    +3060     
==========================================
+ Hits         2565     3635    +1070     
- Misses       3334     5324    +1990

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamishcoleman hamishcoleman merged commit b952ae7 into n42n:main Feb 12, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hamishcoleman hamishcoleman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishcoleman @codecov-commenter