JsonRPC support replaces the old API #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…single use structures
Since the number of options being given to each compile is probably only going to increase, the ability to read and understand the compile output is only going to become harder. Address this by outputing the generic CC line once and then just show the name of each file that is being compiled. Note that we deliberately do not do this for the apps/ directory as we want that to stay as simple as possible so that people can easily use it as a template to write their own app.
…ump format with this
This restores the load_dump back to its function as part of the test suite, but renames it reflect its actual function of testing roundtrip load/dump of a config file. The debug menu is the place to put random internal debug output.
Windows mangled the command line arg "/dev/null" into something that the find config files function turned into a session name of "nul", so just output it for the operator to see - and dont include it in the expected data.
None of the signal handling features are linux specific, nor is the term handler only going to work on linux and windows, so just use the same one everywhere.
Previously, the windows code would wait for an unknown amount of time until the tun_read_thread exited. That thread is constantly performing infinite length waits for new packets to be ready to read from the tap interface - so until a packet arrives, it will stall the daemon exit. Having looked through the wintap overlapped read handling, it seems like there could be some general improvements possible, so I will use this simple terminate thread option until that refactoring can change the way things work.
… helper for adaptor names
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 43.79% 38.23% -5.57%
==========================================
Files 38 51 +13
Lines 5754 8898 +3144
==========================================
+ Hits 2520 3402 +882
- Misses 3234 5496 +2262 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tools still need porting to the new API, but all server features are present, working and documented. There is still plenty of room for improvements, but this branch contains the framework and expected minimum features.
One nice feature is that there is now a built in HTTP webpage that allows tool-free access to the running status on any system where there is a web browser (specifically, Windows, where you cannot expect people to run a python script)
Also: