-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[response-cache] deprecate ttlPerType
option in favor of ttlPerSchemaCoordinate
#2258
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: c72a736 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3e0ba79
to
c72a736
Compare
🚀 Snapshot Release (
|
Package | Version | Info |
---|---|---|
@envelop/response-cache |
6.3.0-alpha-20240710083620-c72a7363 |
npm ↗︎ unpkg ↗︎ |
@envelop/response-cache-cloudflare-kv |
2.0.0-alpha-20240710083620-c72a7363 |
npm ↗︎ unpkg ↗︎ |
💻 Website PreviewThe latest changes are available as preview in: https://14a7b1b8.envelop.pages.dev |
✅ Benchmark Results
|
I just realized that I didn't updated tests. I have to do this before merging. |
Description
There is an incoherence in the options API. TTL is configured using 2 parameters:
ttlPerType
andttlPerSchemaCoordinate
while scope is configured only viascopeBySchemaCoordinate
which can contain typeName only or typeName+fieldName keys.This PR is deprecating the
ttlPerType
in favor ofttlPerSchemaCoordinate
to be more coherent.ttlPerType
is still supported but will be removed in future major release.Type of change