Add support for frameTimeout option #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a frameTimeout option that can be passed a Duration. The option is expected to be used with streams where isLive=true, so that there is a timeout between receiving frames. If no new frame is received for the given timeout duration, the stream is automatically reloaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the request from #36.
This adds a
frameTimeoutoption that can be passed a Duration. The option is expected to be used with streams whereisLive=true, so that there is a timeout between receiving frames. If no new frame is received for the given timeout duration, the stream is automatically reloaded.We have been using this in our desktop app to get streams to reload after the machine entered sleep mode and it has worked very well for the past (almost) two months.