Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option for using a single database #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mxdev88
Copy link

@mxdev88 mxdev88 commented May 16, 2021

This PR implements an option for ScrapydWeb to use a single database. This is useful when used in environement where user does not have the priviliege to create database (e.g. Heroku).

It is assumed the user will not go from one mode to the other (single vs. multiple) and if it is the case, data migration would have to be managed outside the application if need be.

This would allow use cases mentioned in #176, #151 and #139.

@pep8speaks
Copy link

pep8speaks commented May 16, 2021

Hello @mxdev88! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-16 11:52:39 UTC

@mxdev88 mxdev88 force-pushed the single-database branch from 2793fd6 to 279f6ff Compare May 16, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants