Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for scaling BPM by different ratios using ControlPushButton #1

Merged
merged 3 commits into from
May 22, 2024

Conversation

mxmilkiib
Copy link
Owner

This change introduces the ability to scale the BPM of a track by different
ratios using ControlPushButton objects. Each button is connected to a lambda
function that calls the slotScaleBpm method with the corresponding BPM scale
factor.

@github-actions github-actions bot added the engine label Mar 7, 2024
@coveralls
Copy link

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 9142569028

Details

  • 411 of 2270 (18.11%) changed or added relevant lines in 103 files are covered.
  • 175 unchanged lines in 53 files lost coverage.
  • Overall coverage decreased (-0.2%) to 30.951%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controllers/bulk/bulkenumerator.cpp 0 1 0.0%
src/controllers/hid/hidioglobaloutputreportfifo.cpp 0 1 0.0%
src/effects/backends/builtin/compressoreffect.h 0 1 0.0%
src/library/playlisttablemodel.cpp 2 3 66.67%
src/library/rhythmbox/rhythmboxfeature.cpp 0 1 0.0%
src/library/trackset/playlistfeature.cpp 5 6 83.33%
src/library/traktor/traktorfeature.cpp 0 1 0.0%
src/mixer/basetrackplayer.h 0 1 0.0%
src/musicbrainz/web/coverartarchivelinkstask.cpp 0 1 0.0%
src/preferences/dialog/dlgpreferences.cpp 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/widget/wslidercomposed.cpp 1 0.0%
src/widget/wvumeterglsl.cpp 1 0.0%
src/library/serato/seratofeature.cpp 1 11.91%
src/track/track.cpp 1 60.18%
src/engine/controls/cuecontrol.cpp 1 69.55%
src/waveform/waveformwidgetfactory.cpp 1 0.0%
src/preferences/dialog/dlgpreferences.cpp 1 0.0%
src/waveform/renderers/allshader/waveformrendererrgb.cpp 1 0.0%
src/widget/openglwindow.cpp 1 0.0%
src/widget/weffectchainpresetbutton.cpp 1 0.0%
Totals Coverage Status
Change from base Build 8666677785: -0.2%
Covered Lines: 31701
Relevant Lines: 102423

💛 - Coveralls

@mxmilkiib mxmilkiib force-pushed the Add-bpm-scaling-controls branch 8 times, most recently from 5ad8971 to caf6bd6 Compare March 17, 2024 09:44
@mxmilkiib mxmilkiib force-pushed the Add-bpm-scaling-controls branch from 85e97ba to 3f8ac55 Compare March 25, 2024 03:03
@mxmilkiib
Copy link
Owner Author

Um, not sure how to squish those commits.

@ronso0 ronso0 force-pushed the Add-bpm-scaling-controls branch from 5daa61c to 1fa0c48 Compare May 11, 2024 19:49
@mxmilkiib mxmilkiib merged commit de2b3ec into main May 22, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants