Skip to content

Commit

Permalink
Update src/engine/controls/bpmcontrol.cpp
Browse files Browse the repository at this point in the history 
newBeats is a pointer already

Co-authored-by: ronso0 <[email protected]>
  • Loading branch information
@mxmilkiib @ronso0
mxmilkiib and ronso0 authored Apr 12, 2024
1 parent 3f8ac55 commit 8d64376
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/engine/controls/bpmcontrol.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ void BpmControl::slotScaleBpm(mixxx::Beats::BpmScale bpmScale) {
if (!newBeats) {
return;
}
pTrack->trySetBeats(*newBeats);
pTrack->trySetBeats(newBeats);

Check failure on line 350 in src/engine/controls/bpmcontrol.cpp

View workflow job for this annotation

GitHub Actions / clazy 

no viable conversion from 'const std::optional<std::shared_ptr<const mixxx::Beats>>' to 'mixxx::BeatsPointer' (aka 'shared_ptr<const mixxx::Beats>')

Check failure on line 350 in src/engine/controls/bpmcontrol.cpp

View workflow job for this annotation

GitHub Actions / clang-tidy 

no viable conversion from 'const std::optional<BeatsPointer>' (aka 'const optional<shared_ptr<const mixxx::Beats>>') to 'mixxx::BeatsPointer' (aka 'shared_ptr<const mixxx::Beats>') [clang-diagnostic-error]

Check failure on line 350 in src/engine/controls/bpmcontrol.cpp

View workflow job for this annotation

GitHub Actions / Ubuntu 22.04 

cannot convert ‘const std::optional<std::shared_ptr<const mixxx::Beats> >’ to ‘mixxx::BeatsPointer’ {aka ‘std::shared_ptr<const mixxx::Beats>’}

Check failure on line 350 in src/engine/controls/bpmcontrol.cpp

View workflow job for this annotation

GitHub Actions / macOS 11 x64 

no viable conversion from 'const std::optional<std::shared_ptr<const mixxx::Beats>>' to 'mixxx::BeatsPointer' (aka 'shared_ptr<const mixxx::Beats>')

Check failure on line 350 in src/engine/controls/bpmcontrol.cpp

View workflow job for this annotation

GitHub Actions / coverage 

cannot convert ‘const std::optional<std::shared_ptr<const mixxx::Beats> >’ to ‘mixxx::BeatsPointer’ {aka ‘std::shared_ptr<const mixxx::Beats>’}

Check failure on line 350 in src/engine/controls/bpmcontrol.cpp

View workflow job for this annotation

GitHub Actions / macOS 11 arm64 

no viable conversion from 'const std::optional<std::shared_ptr<const mixxx::Beats>>' to 'mixxx::BeatsPointer' (aka 'shared_ptr<const mixxx::Beats>')

Check failure on line 350 in src/engine/controls/bpmcontrol.cpp

View workflow job for this annotation

GitHub Actions / Windows 2019 (MSVC) 

'bool Track::trySetBeats(mixxx::BeatsPointer)': cannot convert argument 1 from 'const std::optional<mixxx::BeatsPointer>' to 'mixxx::BeatsPointer'
}

// static
Expand Down

0 comments on commit 8d64376

Please sign in to comment.