Sanitize internal storage file names #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Alphastaire I need time to test this. |
mxlgv
requested changes
Aug 16, 2024
Alphastaire
force-pushed
the
windows-sanitize-filenames
branch
from
3374ac0 to
354d81d
Compare
mxlgv
requested changes
Aug 17, 2024
Sanitize an internally downloaded file's name during save process to prevent file transfer error for Windows users and potentially Linux users.
Alphastaire
force-pushed
the
windows-sanitize-filenames
branch
from
0ad67f3 to
8e94578
Compare
mxlgv
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanitize an internally downloaded file's name during save process to prevent file transfer error for Windows users. We do this via regex that finds specific characters (
\/:*?"<>|) and replaces them with underscores. This will only affect the file names for internal storage. Users will still see the intended file name through the client since that's how the system is built.This is a simple solution for #86.