Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show contact status in "Start chat" window #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eerielili
Copy link

Should close dino#139 and come in handy to know when someone is online or busy before opening a new chat with them.

Online:
image

DND:
image

Away and extended away:
image

Offline:
image

There's also the "open for chats / wanting to chat" status with this icon:
image
But i couldn't test it out. I still included it in the code.

@eerielili eerielili force-pushed the show-contact-status-in-start-chat-window branch from 541f9ea to 08d9ba3 Compare June 15, 2024 22:57
@eerielili
Copy link
Author

Corrected some ){ to ) { with the force-push.

@mxlgv
Copy link
Owner

mxlgv commented Aug 5, 2024

@giantplaceholder It seems we had something similar, but at the same time we rolled back. Can you tell me why
#68

@giantplaceholder
Copy link
Collaborator

@mxlgv @eerielili
I'm pretty sure that we've used @eerielili's PR as a base back then. It was not operating properly in anonymous MUCs, only in those where JIDs of participants were publicly available.

@mxlgv
Copy link
Owner

mxlgv commented Aug 8, 2024

@giantplaceholder What's wrong with it not working in anonymous MUC? It's better for it to work somewhere than nowhere at all. Or are there hidden problems?

@giantplaceholder
Copy link
Collaborator

@giantplaceholder What's wrong with it not working in anonymous MUC? It's better for it to work somewhere than nowhere at all. Or are there hidden problems?

Take a look at how upstreams works: we don't an explicit status of the user, but we assume that some are online - we can see admins, recently posted users and so on.

image

Now, if we were to apply your PR, we won't see proper status for any of those users, and in my case, the user list fails to show more than one MUC occupant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Show contact status in "Start Chat" window
3 participants