Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGPG plugin: Don't list expired/revoked GPG key #57

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

vlomovtsev
Copy link
Collaborator

@vlomovtsev vlomovtsev commented Apr 17, 2024

This PR implement following changes:

  • closes Potential social engineering vulnerability in Windows #91
  • Mention that GPG key may be expired or revoked: in the account dialog if the number of OpenPGP keys found is 0, the label also notes that a key may have been revoked or expired.
  • blocks input in chat box if key is use is revoked or expired

Original changes are picked up from the following one: eerielili@2f3ddad

@mxlgv mxlgv changed the title OPENPGP PLUGIN: Don't list expired/revoked GPG key OpenGPG plugin: Don't list expired/revoked GPG key Apr 17, 2024
plugins/openpgp/src/gpgme_helper.vala Outdated Show resolved Hide resolved
plugins/openpgp/src/encryption_list_entry.vala Outdated Show resolved Hide resolved
plugins/openpgp/src/encryption_list_entry.vala Outdated Show resolved Hide resolved
This commit is to implement follwoing changes:
 - closes mxlgv#91;
 - Mention that GPG key may be expired or revoked:
   in the account dialog if the number of OpenPGP keys found is 0,
   the label also notes that a key may have been revoked or expired;
 - blocks input in chat box if key is use is revoked or expired;

(cherry picked from commit 2f3ddad)
Signed-off-by: Vadim Lomovtsev <[email protected]>
@mxlgv mxlgv merged commit 8f4d789 into mxlgv:master Apr 17, 2024
4 checks passed
VadimNk pushed a commit to VadimNk/dino that referenced this pull request Apr 18, 2024
This commit is to implement follwoing changes:
 - closes mxlgv#91;
 - Mention that GPG key may be expired or revoked:
   in the account dialog if the number of OpenPGP keys found is 0,
   the label also notes that a key may have been revoked or expired;
 - blocks input in chat box if key is use is revoked or expired;

(cherry picked from commit 2f3ddad)
Signed-off-by: Vadim Lomovtsev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not allow revoked GPG keys
3 participants