Modernize translation infrastructure #75
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrdrag
reviewed
Sep 13, 2020
| ../alexandria.desktop.in.h: ../alexandria.desktop.in | ||
| intltool-extract --type=gettext/ini ../alexandria.desktop.in | ||
| @echo Updating PO template from desktop file | ||
| @xgettext --output=$(POT) --join-existing $(DESKTOP) |
There was a problem hiding this comment.
I think gettext doesn’t need _ tags in the .desktop file, right?
There was a problem hiding this comment.
You're right. I'm going to have to adjust the tasks in the main Rakefile as well.
mvz
force-pushed
the
modernize-translation-infrastructure
branch
from
ce33dd9
to
9531af8
Compare
mvz
force-pushed
the
modernize-translation-infrastructure
branch
from
9531af8
to
2cdbed1
Compare
mvz
force-pushed
the
modernize-translation-infrastructure
branch
2 times, most recently
from
e815b19
to
fadf62d
Compare
mvz
force-pushed
the
modernize-translation-infrastructure
branch
from
fadf62d
to
1174f35
Compare
mvz
force-pushed
the
modernize-translation-infrastructure
branch
from
1174f35
to
381a88b
Compare
mvz
force-pushed
the
modernize-translation-infrastructure
branch
2 times, most recently
from
ca863cc
to
e5ac92a
Compare
- Use xgettext to extract translations from desktop file directly, avoiding the need to use intltool - Make git ignore translation build artifacts
mvz
force-pushed
the
modernize-translation-infrastructure
branch
from
e5ac92a
to
072678d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43