Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more tests and Pep8 fixes #279

Merged
merged 4 commits into from
Feb 3, 2021
Merged

Conversation

lordlabuckdas
Copy link
Contributor

@lordlabuckdas lordlabuckdas commented Dec 12, 2020

  • Added more tests and fixed some existing ones

  • Coverage increased from 65% to 91% (tested locally with pytest)

  • Pep8 fixes to the whole repo

Edit:

  • Fixed long strings to comply with pep8

  • Changed permissions of 2 test files (from 755 to 644), they were skipped in testing because of executable permissions

  • Changed format-strings to string concatenation to add python3.5 support

Ref #187

* coverage increased from 65% to 91%

* pep8 fixes
* changed permissions of 2 test files
@glaslos
Copy link
Member

glaslos commented Dec 18, 2020

Fixed long strings to comply with pep8

@afeena or @viskey98 do you remember what line length we accept? I don't think we go strict pep8 (I also disagree with the 80 chars).

@lordlabuckdas
Copy link
Contributor Author

lordlabuckdas commented Dec 18, 2020

@glaslos, Travis CI's pycodestyle has --max-line-length 120. So, if that's the desired character length, I'll reformat my branch to comply with it.

@glaslos
Copy link
Member

glaslos commented Dec 19, 2020

@lordlabuckdas that sounds about right 👍

Copy link
Member

@glaslos glaslos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work and thanks for adding tests and cleaning the code!

@afeena
Copy link
Collaborator

afeena commented Feb 3, 2021

Thanks @lordlabuckdas :) looks great!

@afeena afeena merged commit 5af7675 into mushorg:master Feb 3, 2021
@lordlabuckdas
Copy link
Contributor Author

Glad I could be of help 😄

@lordlabuckdas lordlabuckdas deleted the add_tests branch February 3, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants