Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage #187

Open
glaslos opened this issue Mar 9, 2019 · 3 comments
Open

Increase test coverage #187

glaslos opened this issue Mar 9, 2019 · 3 comments
Labels
good first contribution

Comments

@glaslos
Copy link
Member

glaslos commented Mar 9, 2019 •
edited
Loading

There is plenty of opportunity to add more tests to SNARE. We make a lot of assumptions and with GSoC approaching, we should make sure the critical paths are covered.
@glaslos glaslos changed the title Create some basic test coverage Increase test coverage Mar 9, 2019
@amanjiofficial
Copy link
Contributor

amanjiofficial commented Mar 10, 2019 •
edited
Loading

@glaslos Can you please describe the test to be added with an example.

@glaslos
Copy link
Member Author

glaslos commented Mar 10, 2019 via email

@amanjiofficial
Copy link
Contributor

I am working on this issue I will update soon

This was referenced Mar 14, 2019
Merged
Merged
Parth1811 added a commit to Parth1811/snare that referenced this issue Mar 8, 2020
@Parth1811
Added tests for Cloner.add_schema
ef0c09e 
Handled the case when there is no proper host provided and also added tests for the cases when host provided has length less than 4 which indicates no proper domain was provided.
Refs mushorg#187
@Parth1811 Parth1811 mentioned this issue Mar 8, 2020
Merged
Parth1811 added a commit to Parth1811/snare that referenced this issue Mar 8, 2020
@Parth1811
Added tests for Cloner.add_schema
9a46564 
Handled the case when there is no proper host provided and also added tests for the cases when host provided has length less than 4 which indicates no proper domain was provided.
Refs mushorg#187
afeena pushed a commit that referenced this issue Mar 10, 2020
@Parth1811
Added tests for Cloner.add_schema (#260)
61760c1 
Handled the case when there is no proper host provided and also added tests for the cases when host provided has length less than 4 which indicates no proper domain was provided.
Refs #187
@lordlabuckdas lordlabuckdas mentioned this issue Dec 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glaslos @afeena @amanjiofficial