Smtp responses fixed and random wait added #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furusiyya
reviewed
Apr 4, 2017
smtp.go
Outdated
| client.w("250 OK") | ||
| } else if strings.Compare(query, "DATA") == 0 { | ||
| client.w("354 End data with <CRLF>.<CRLF>") | ||
| for strings.Compare(client.r(g), ".\r\n") != 0 { |
There was a problem hiding this comment.
May be you want to add limit over reading data. Like break the loop when condition len(data) > dataVerbMaxLength comes true.
I think dataVerbMaxLength should be a constant.
Second Comment: You should log data you are reading
furusiyya
suggested changes
Apr 4, 2017
furusiyya
reviewed
Apr 4, 2017
smtp.go
Outdated
| @@ -9,6 +9,9 @@ import ( | |||
| "time" | |||
| ) | |||
|
|
|||
| // maximum lines that can be read after the "DATA" command | |||
| var maxDataRead int = 500 | |||
There was a problem hiding this comment.
I made a commit like 10 seconds before you commented haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a step towards fixing #53 and #25.
Better SMPT mimicking and adds random response time (only for port 25, not global)