Generate standard drumset from online instruments spreadsheet #26082
+289
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spreadsheet is now the source of truth for all instrument data.
|
Why don't you add that spreadsheed to the repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spreadsheet is now the source of truth for all instrument data, which makes it more convienient for @zacjansheski to edit.
By keeping the standard drumset in the C++ code, we ensure it is available to engraving, playback, MIDI & MusicXML import systems during startup, prior to
instruments.xmlbeing loaded.Replaces PR #25759, which caused problems for MIDI import, and potentially for other things too.