Percussion panel - refinements round 5 #26075
Open
+155
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Automatically resize panel to fit number of rows - Disable duplicate pad functionality for now - Update note input state on undo stack changed - Fix inconsistent panel behaviour on copy/paste (set selection m_activeTrack) - Don't use dashes for empty shortcut - Restore deleted pads on reset layout
mathesoncalum
force-pushed
the
percussion_refinements_5
branch
from
59a197b to
9dcbfac
Compare
RomanPudashkin
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this round of refinements:
Assorted small fixes (7469191)
PercussionPanel.qml). Unfortunately we have some technical limitations relating toDockBase::resizemeaning the panel will only increase in size to fit the pads and can't shrink.percussionpanelpadmodel.cpp)notationinteraction.cpp)select.cpp)percussionpanelpadlistmodel.cpp). This also fixes a bug where the undo stack was being altered unnecessarily.percussionpanelpadlistmodel.cpp)Percussion preferences tweaks (68e434e)
Implemented small UI changes to percussion preferences per designers' request. Choosing the legacy panel option now disables new panel options instead of hiding them.
Fixed bug when switching voices while entering notes (9dcbfac)
Resolves: #22741
This was a general limitation of our note input logic. While adding notes to "overlapping
ChordRests" was made possible in other contexts after #23911, the logic was still missing fromScore::addPitch(the method used by the percussion panel and piano keyboard).