Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong corruption message #26053

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cbjeukendrup
Copy link
Contributor

Resolves: #20728

@cbjeukendrup cbjeukendrup force-pushed the wrong_measure_length_corruption_message branch from b1279a2 to a4c6a29 Compare January 10, 2025 23:35
@cbjeukendrup cbjeukendrup marked this pull request as ready for review January 10, 2025 23:40
@Jojo-Schmitz
Copy link
Contributor

See my test at #20728 (comment)

@Jojo-Schmitz
Copy link
Contributor

It seems the method to open scores in downrev version described in https://musescore.org/en/node/367704 doesn't work anymore with 4.5 down to 4.4.4? Which is a pity, now that this PR fixes those 'broken' fractions. (3.7 opens them just fine, once saved with this PR's artifact). Is this a regression of this PR or did it break earlier already?

@cbjeukendrup
Copy link
Contributor Author

I think that may have to do with the change in how element IDs are written (see also #25736). So I'm afraid that's unavoidable.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jan 11, 2025

I see. Pity.
(not entirely unavoidable as 3.7 proves, but would require a 4.4.5 and still not work for anything earlier)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bogus and useless corruption message
2 participants